Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint errors using deno lint --fix #906

Merged
merged 2 commits into from
Aug 31, 2024
Merged

Fix lint errors using deno lint --fix #906

merged 2 commits into from
Aug 31, 2024

Conversation

taras
Copy link
Member

@taras taras commented Aug 31, 2024 •
edited
Loading

Motivation

#905 is blocked because of lint errors, so I will fix them here and then rebase.

Approach

  1. Ran deno lint --fix
  2. Using npm:process instead of globalThis.process
  3. Pinned to 1.46.x in CI

@taras taras requested a review from cowboyd August 31, 2024 16:27
@taras taras enabled auto-merge August 31, 2024 16:41
@cowboyd
Copy link
Member

cowboyd commented Aug 31, 2024

Might have been caused by the Deno default linting rules changing in between point releases of Deno. We may want to pin our Dino version in the set up Dino action so that this doesn't happen in the future.

@taras
Copy link
Member Author

taras commented Aug 31, 2024 •
edited
Loading

@cowboyd I'll do this in a separate PR. I'll do it here.

@taras taras merged commit fb56b78 into v3 Aug 31, 2024
3 checks passed
@taras taras deleted the tm/fix-lint-errors branch August 31, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowboyd cowboyd cowboyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taras @cowboyd